From 756b28dca0dc86e38157cbf17cfafb3818b33412 Mon Sep 17 00:00:00 2001 From: LisoUseInAIKyrios <118716522+LisoUseInAIKyrios@users.noreply.github.com> Date: Wed, 11 Jun 2025 19:57:37 +0200 Subject: [PATCH] chore: Fix debug logging if context is not set --- .../java/app/revanced/extension/shared/Logger.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/extensions/shared/library/src/main/java/app/revanced/extension/shared/Logger.java b/extensions/shared/library/src/main/java/app/revanced/extension/shared/Logger.java index 437a56420..47f6da3e3 100644 --- a/extensions/shared/library/src/main/java/app/revanced/extension/shared/Logger.java +++ b/extensions/shared/library/src/main/java/app/revanced/extension/shared/Logger.java @@ -139,14 +139,20 @@ public class Logger { } } - private static boolean includeStackTrace() { - return Utils.context != null && DEBUG_STACKTRACE.get(); + private static boolean shouldLogDebug() { + // If the app is still starting up and the context is not yet set, + // then allow debug logging regardless what the debug setting actually is. + return Utils.context == null || DEBUG.get(); } private static boolean shouldShowErrorToast() { return Utils.context != null && DEBUG_TOAST_ON_ERROR.get(); } + private static boolean includeStackTrace() { + return Utils.context != null && DEBUG_STACKTRACE.get(); + } + /** * Logs debug messages under the outer class name of the code calling this method. *

@@ -166,7 +172,7 @@ public class Logger { * building strings is paid only if {@link BaseSettings#DEBUG} is enabled. */ public static void printDebug(LogMessage message, @Nullable Exception ex) { - if (DEBUG.get()) { + if (shouldLogDebug()) { logInternal(LogLevel.DEBUG, message, ex, includeStackTrace(), false); } }