From e1fc9912c41527aa28f7c46d5390ec5e258d69e3 Mon Sep 17 00:00:00 2001 From: LisoUseInAIKyrios <118716522+LisoUseInAIKyrios@users.noreply.github.com> Date: Thu, 5 Jun 2025 11:08:24 +0200 Subject: [PATCH] refactor(YouTube - Hide Shorts components): Rename 'Hide comment panel' to 'Hide preview comment' --- .../extension/youtube/patches/components/ShortsFilter.java | 2 +- .../app/revanced/extension/youtube/settings/Settings.java | 2 +- .../youtube/layout/hide/shorts/HideShortsComponentsPatch.kt | 2 +- patches/src/main/resources/addresources/values/strings.xml | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/ShortsFilter.java b/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/ShortsFilter.java index 752cca7cb..2bacb34e9 100644 --- a/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/ShortsFilter.java +++ b/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/components/ShortsFilter.java @@ -218,7 +218,7 @@ public final class ShortsFilter extends Filter { // suggestedActionsGroupList.addAll( new ByteArrayFilterGroup( - Settings.HIDE_SHORTS_COMMENT_PANEL, + Settings.HIDE_SHORTS_PREVIEW_COMMENT, // Preview comment that can popup while a Short is playing. // Uses no bundled icons, and instead the users profile photo is shown. "shorts-comments-panel" diff --git a/extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java b/extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java index f52865799..894c6af3d 100644 --- a/extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java +++ b/extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java @@ -275,7 +275,7 @@ public class Settings extends BaseSettings { public static final BooleanSetting HIDE_SHORTS_SEARCH = new BooleanSetting("revanced_hide_shorts_search", FALSE); public static final BooleanSetting HIDE_SHORTS_SEARCH_SUGGESTIONS = new BooleanSetting("revanced_hide_shorts_search_suggestions", TRUE); public static final BooleanSetting HIDE_SHORTS_SHARE_BUTTON = new BooleanSetting("revanced_hide_shorts_share_button", FALSE); - public static final BooleanSetting HIDE_SHORTS_COMMENT_PANEL = new BooleanSetting("revanced_hide_shorts_comment_panel", TRUE); + public static final BooleanSetting HIDE_SHORTS_PREVIEW_COMMENT = new BooleanSetting("revanced_hide_shorts_preview_comment", TRUE); public static final BooleanSetting HIDE_SHORTS_SHOP_BUTTON = new BooleanSetting("revanced_hide_shorts_shop_button", TRUE); public static final BooleanSetting HIDE_SHORTS_SOUND_BUTTON = new BooleanSetting("revanced_hide_shorts_sound_button", FALSE); public static final BooleanSetting HIDE_SHORTS_SOUND_METADATA_LABEL = new BooleanSetting("revanced_hide_shorts_sound_metadata_label", FALSE); diff --git a/patches/src/main/kotlin/app/revanced/patches/youtube/layout/hide/shorts/HideShortsComponentsPatch.kt b/patches/src/main/kotlin/app/revanced/patches/youtube/layout/hide/shorts/HideShortsComponentsPatch.kt index 551a109f7..970cc2260 100644 --- a/patches/src/main/kotlin/app/revanced/patches/youtube/layout/hide/shorts/HideShortsComponentsPatch.kt +++ b/patches/src/main/kotlin/app/revanced/patches/youtube/layout/hide/shorts/HideShortsComponentsPatch.kt @@ -92,7 +92,7 @@ private val hideShortsComponentsResourcePatch = resourcePatch { SwitchPreference("revanced_hide_shorts_paused_overlay_buttons"), // Suggested actions. - SwitchPreference("revanced_hide_shorts_comment_panel"), + SwitchPreference("revanced_hide_shorts_preview_comment"), SwitchPreference("revanced_hide_shorts_save_sound_button"), SwitchPreference("revanced_hide_shorts_use_template_button"), SwitchPreference("revanced_hide_shorts_upcoming_button"), diff --git a/patches/src/main/resources/addresources/values/strings.xml b/patches/src/main/resources/addresources/values/strings.xml index 2aed55eba..428f29731 100644 --- a/patches/src/main/resources/addresources/values/strings.xml +++ b/patches/src/main/resources/addresources/values/strings.xml @@ -812,9 +812,9 @@ To show the Audio track menu, change \'Spoof video streams\' to iOS TV" Hide location label Location label is hidden Location label is shown - Hide Comment panel - Comment panel is hidden - Comment panel is shown + Hide preview comment + Preview comment is hidden + Preview comment is shown Hide Save music button Save music button is hidden Save music button is shown