refactor(Spotify): Add extensions debug logging (#5110)

This commit is contained in:
Nuckyz
2025-06-05 16:04:02 -03:00
committed by GitHub
parent 617d925fcf
commit f2ca0eeac0
10 changed files with 101 additions and 27 deletions

View File

@ -72,7 +72,7 @@ val hideCreateButtonPatch = bytecodePatch(
if (oldNavigationBarAddItemMethod != null) {
// In case an older version of the app is being patched, hook the old method which adds navigation bar items.
// Return null early if the navigation bar item title resource id is old Create button title resource id.
// Return null early if the navigation bar item title resource id is the old Create button title resource id.
oldNavigationBarAddItemFingerprint.methodOrNull?.apply {
val getNavigationBarItemTitleStringIndex = indexOfFirstInstructionOrThrow {
val reference = getReference<MethodReference>()

View File

@ -129,7 +129,7 @@ val customThemePatch = resourcePatch(
val accentColorPressed by stringOption(
key = "accentColorPressed",
default = "#FF1ABC54",
title = "Pressed dark theme accent color",
title = "Pressed accent color",
description = "The color when accented buttons are pressed, by default slightly darker than accent. " +
"Can be a hex color or a resource reference.",
required = true,

View File

@ -38,7 +38,7 @@ val unlockPremiumPatch = bytecodePatch(
// so for now this is a dependent of this patch.
//
// FIXME: Modifying string resources (such as adding patch strings)
// is currently failing with ReVanced manager.
// is currently failing with ReVanced Manager.
// checkEnvironmentPatch,
)
@ -78,7 +78,7 @@ val unlockPremiumPatch = bytecodePatch(
if (IS_SPOTIFY_LEGACY_APP_TARGET) {
Logger.getLogger(this::class.java.name).warning(
"Patching a legacy Spotify version. Patch functionality may be limited."
"Patching a legacy Spotify version. Patch functionality may be limited."
)
return@execute
}
@ -174,7 +174,7 @@ val unlockPremiumPatch = bytecodePatch(
// Need to allow mutation of the list so the home ads sections can be removed.
// Protobuf array list has an 'isMutable' boolean parameter that sets the mutability.
// Forcing that always on breaks unrelated code in strange ways.
// Instead, return early in the method that throws an error if the list is unmutable.
// Instead, return early in the method that throws an error if the list is immutable.
abstractProtobufListEnsureIsMutableFingerprint.match(abstractProtobufListClassDef)
.method.returnEarly()

View File

@ -15,7 +15,7 @@ val fixFacebookLoginPatch = bytecodePatch(
// The Facebook SDK tries to handle the login using the Facebook app in case it is installed.
// However, the Facebook app does signature checks with the app that is requesting the authentication,
// which ends up making the Facebook server reject with an invalid key hash for the app signature.
// Override the Faceboook SDK to always handle the login using the web browser, which does not perform
// Override the Facebook SDK to always handle the login using the web browser, which does not perform
// signature checks.
val katanaProxyLoginMethodHandlerClass = katanaProxyLoginMethodHandlerClassFingerprint.originalClassDef

View File

@ -1,7 +1,6 @@
package app.revanced.patches.spotify.misc.widgets
import app.revanced.patcher.fingerprint
import app.revanced.util.indexOfFirstInstruction
import com.android.tools.smali.dexlib2.Opcode
internal val canBindAppWidgetPermissionFingerprint = fingerprint {